Messages in this thread | | | Date | Thu, 8 Nov 2012 06:42:39 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 7/9] cgroup_freezer: introduce CGROUP_FREEZING_[SELF|PARENT] |
| |
Hello,
On Thu, Nov 08, 2012 at 01:47:55PM +0100, Michal Hocko wrote: > On Sat 03-11-12 01:38:33, Tejun Heo wrote: > > Introduce FREEZING_SELF and FREEZING_PARENT and make FREEZING OR of > > the two flags. This is to prepare for full hierarchy support. > > > > freezer_apply_date() is updated such that it can handle setting and > > clearing of both flags. The two flags are also exposed to userland > > via read-only files self_freezing and parent_freezing. > > > > Other than the added cgroupfs files, this patch doesn't introduce any > > behavior change. > > OK, I can imagine that this might be useful to find the first parent > group that needs to be thawed to unfreeze the group I am interested > in. Could you also update Documentation/cgroups/freezer-subsystem.txt to > clarify the intended usage?
Ooh, right. Will update the doc in the last patch.
> Minor nit. Same as mentioned in the previous patch freezer_apply_state > should get enum freezer_state_flags state parameter.
But it isn't an enum value.
Thanks.
-- tejun
| |