lkml.org 
[lkml]   [2012]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/9] cgroup_freezer: introduce CGROUP_FREEZING_[SELF|PARENT]
    (2012/11/08 13:45), Tejun Heo wrote:
    > Hello,
    >
    > On Thu, Nov 08, 2012 at 01:42:22PM +0900, Kamezawa Hiroyuki wrote:
    >> (2012/11/03 17:38), Tejun Heo wrote:
    >>> Introduce FREEZING_SELF and FREEZING_PARENT and make FREEZING OR of
    >>> the two flags. This is to prepare for full hierarchy support.
    >>>
    >>> freezer_apply_date() is updated such that it can handle setting and
    >>> clearing of both flags. The two flags are also exposed to userland
    >>> via read-only files self_freezing and parent_freezing.
    >>>
    >>> Other than the added cgroupfs files, this patch doesn't introduce any
    >>> behavior change.
    >>>
    >>> Signed-off-by: Tejun Heo <tj@kernel.org>
    >>
    >> What is the purpose of FREEZING_SELG/PARENT, having 2 flags and
    >> make it visible to users ?
    >
    > SELF is the configuration of the current cgroup, PARENT is freezing
    > state inherited from an ancestor. If either is set, the cgroup is
    > freezing. Without the two conditions visible to userland, it can get
    > a bit confusing as echoing "THAWED" to state may not do anything to
    > the cgroup.
    >
    Got it, thank you. I'm glad if you add some more explanation in comments
    and considered use-case in changelog.

    Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

    Thanks,
    -Kame







    \
     
     \ /
      Last update: 2012-11-08 06:45    [W:2.766 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site