Messages in this thread | | | Date | Mon, 5 Nov 2012 13:40:05 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 5/8] cgroup: remove CGRP_WAIT_ON_RMDIR, cgroup_exclude_rmdir() and cgroup_release_and_wakeup_rmdir() |
| |
On 2012/11/1 3:44, Tejun Heo wrote: > CGRP_WAIT_ON_RMDIR is another kludge which was added to make cgroup > destruction rollback somewhat working. cgroup_rmdir() used to drain > CSS references and CGRP_WAIT_ON_RMDIR and the associated waitqueue and > helpers were used to allow the task performing rmdir to wait for the > next relevant event. > > Unfortunately, the wait is visible to controllers too and the > mechanism got exposed to memcg by 887032670d ("cgroup avoid permanent > sleep at rmdir"). > > Now that the draining and retries are gone, CGRP_WAIT_ON_RMDIR is > unnecessary. Remove it and all the mechanisms supporting it. Note > that memcontrol.c changes are essentially revert of 887032670d > ("cgroup avoid permanent sleep at rmdir"). > > Signed-off-by: Tejun Heo <tj@kernel.org> > Reviewed-by: Michal Hocko <mhocko@suse.cz> > Cc: Balbir Singh <bsingharora@gmail.com> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > --- > include/linux/cgroup.h | 21 --------------------- > kernel/cgroup.c | 51 -------------------------------------------------- > mm/memcontrol.c | 24 +----------------------- > 3 files changed, 1 insertion(+), 95 deletions(-)
Acked-by: Li Zefan <lizefan@huawei.com>
| |