lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] cgroup: kill CSS_REMOVED
On 2012/11/1 3:44, Tejun Heo wrote:
> CSS_REMOVED is one of the several contortions which were necessary to
> support css reference draining on cgroup removal. All css->refcnts
> which need draining should be deactivated and verified to equal zero
> atomically w.r.t. css_tryget(). If any one isn't zero, all refcnts
> needed to be re-activated and css_tryget() shouldn't fail in the
> process.
>
> This was achieved by letting css_tryget() busy-loop until either the
> refcnt is reactivated (failed removal attempt) or CSS_REMOVED is set
> (committing to removal).
>
> Now that css refcnt draining is no longer used, there's no need for
> atomic rollback mechanism. css_tryget() simply can look at the
> reference count and fail if it's deactivated - it's never getting
> re-activated.
>
> This patch removes CSS_REMOVED and updates __css_tryget() to fail if
> the refcnt is deactivated. As deactivation and removal are a single
> step now, they no longer need to be protected against css_tryget()
> happening from irq context. Remove local_irq_disable/enable() from
> cgroup_rmdir().
>
> Note that this removes css_is_removed() whose only user is VM_BUG_ON()
> in memcontrol.c. We can replace it with a check on the refcnt but
> given that the only use case is a debug assert, I think it's better to
> simply unexport it.
>
> v2: Comment updated and explanation on local_irq_disable/enable()
> added per Michal Hocko.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reviewed-by: Michal Hocko <mhocko@suse.cz>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Balbir Singh <bsingharora@gmail.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Acked-by: Li Zefan <lizefan@huawei.com>



\
 
 \ /
  Last update: 2012-11-05 07:23    [W:0.132 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site