lkml.org 
[lkml]   [2012]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/8] x86, cleanups: Simplify sync_core() in the case of no CPUID
On 11/29/2012 01:18 PM, Borislav Petkov wrote:
> On Thu, Nov 29, 2012 at 01:06:20PM -0800, H. Peter Anvin wrote:
>> It doesn't matter in that context, as the surrounding MSR references
>> have barriers, but what I'm refering to is the "memory" barrier.
>
> Ok, but the only difference between the two versions is this line:
>
> movl %esi, %ecx # tmp144, ecx
>
> coming from the cpuid_eax() function. So the memory barrier is the same
> and in the right place in both cases.
>

In the case of that one call site, yes, because the MSR references
include the barrier. Other sites, current or future, may not have the
same property.

-hpa




\
 
 \ /
  Last update: 2012-11-29 22:41    [W:0.049 / U:1.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site