Messages in this thread | | | Date | Thu, 29 Nov 2012 22:18:56 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 8/8] x86, cleanups: Simplify sync_core() in the case of no CPUID |
| |
On Thu, Nov 29, 2012 at 01:06:20PM -0800, H. Peter Anvin wrote: > It doesn't matter in that context, as the surrounding MSR references > have barriers, but what I'm refering to is the "memory" barrier.
Ok, but the only difference between the two versions is this line:
movl %esi, %ecx # tmp144, ecx
coming from the cpuid_eax() function. So the memory barrier is the same and in the right place in both cases.
> The value of ECX doesn't matter when EAX=1.
Ok.
-- Regards/Gruss, Boris.
| |