Messages in this thread | | | From | Vitalii Demianets <> | Subject | Re: [PATCH] drivers/uio/uio_pdrv_genirq.c: Fix memory leak & confusing labels | Date | Wed, 28 Nov 2012 11:37:23 +0200 |
| |
On Wednesday 28 November 2012 02:37:50 Hans J. Koch wrote: > > In other words, the case of uioinfo AND pdev->dev.of_node both being NULL > is not handled properly and will have ugly results. >
Moreover, the case of (uioinfo != NULL) && (pdev->dev.of_node != NULL) leads to equally ugly results too (freeing uoinfo when it is statically allocated).
I think, we should sort out these problems, but in another patch. It is totally unrelated to the problem solved by the original patch (memory leak caused by not freeing priv in case platform_get_irq() fails).
| |