Messages in this thread | | | Date | Wed, 28 Nov 2012 22:14:07 +0100 | From | "Hans J. Koch" <> | Subject | Re: [PATCH] drivers/uio/uio_pdrv_genirq.c: Fix memory leak & confusing labels |
| |
On Wed, Nov 28, 2012 at 11:37:23AM +0200, Vitalii Demianets wrote: > On Wednesday 28 November 2012 02:37:50 Hans J. Koch wrote: > > > > In other words, the case of uioinfo AND pdev->dev.of_node both being NULL > > is not handled properly and will have ugly results. > > > > Moreover, the case of (uioinfo != NULL) && (pdev->dev.of_node != NULL) leads > to equally ugly results too (freeing uoinfo when it is statically allocated).
You're right. That wants to be fixed as well.
> > I think, we should sort out these problems, but in another patch. It is > totally unrelated to the problem solved by the original patch (memory leak > caused by not freeing priv in case platform_get_irq() fails).
So far, no patch was applied. I don't mind if all fixes for uio_pdrv_genirq are in one patch as long as only this one file is altered.
Thanks, Hans
| |