lkml.org 
[lkml]   [2012]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch 7/7] fs, notify: Add procfs fdinfo helper v6
On Wed, 14 Nov 2012 19:19:44 +0400
Cyrill Gorcunov <gorcunov@openvz.org> wrote:

> This allow us to print out fsnotify details such as
> watchee inode, device, mask and optionally a file handle.

This helps the compiler quite a lot:

--- a/fs/notify/fdinfo.c~fs-notify-add-procfs-fdinfo-helper-v7-fix
+++ a/fs/notify/fdinfo.c
@@ -26,13 +26,13 @@ static int show_fdinfo(struct seq_file *
struct fsnotify_mark *mark;
int ret = 0;

- spin_lock(&group->mark_lock);
+ mutex_lock(&group->mark_mutex);
list_for_each_entry(mark, &group->marks_list, g_list) {
ret = show(m, mark);
if (ret)
break;
}
- spin_unlock(&group->mark_lock);
+ mutex_unlock(&group->mark_mutex);
return ret;
}

But I rather worry that the code which you sent clearly wasn't the code
which you tested. Please retest and confirm that I now have the correct
code?



\
 
 \ /
  Last update: 2012-11-27 02:21    [W:0.094 / U:1.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site