Messages in this thread Patch in this message | | | Date | Mon, 26 Nov 2012 16:41:57 -0800 | From | Andrew Morton <> | Subject | Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6 |
| |
On Wed, 14 Nov 2012 19:19:44 +0400 Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> This allow us to print out fsnotify details such as > watchee inode, device, mask and optionally a file handle.
This helps the compiler quite a lot:
--- a/fs/notify/fdinfo.c~fs-notify-add-procfs-fdinfo-helper-v7-fix +++ a/fs/notify/fdinfo.c @@ -26,13 +26,13 @@ static int show_fdinfo(struct seq_file * struct fsnotify_mark *mark; int ret = 0; - spin_lock(&group->mark_lock); + mutex_lock(&group->mark_mutex); list_for_each_entry(mark, &group->marks_list, g_list) { ret = show(m, mark); if (ret) break; } - spin_unlock(&group->mark_lock); + mutex_unlock(&group->mark_mutex); return ret; } But I rather worry that the code which you sent clearly wasn't the code which you tested. Please retest and confirm that I now have the correct code?
| |