Messages in this thread | | | Date | Sat, 17 Nov 2012 11:10:39 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6 |
| |
On Fri, Nov 16, 2012 at 03:56:03PM -0800, Andrew Morton wrote: > > This is a lousy output format. It's sort-of like a sensible set of > name-value tuples: "name:value name:value name:value" but > > a) it has lots of random pointless whitespace after the colons and > > b) several of the labels have spaces in them, just to make life > harder for parsing code and > > c) inotify-wd is secretly printed in decimal while everything else > is in hex. > > What happens if we do something like the below (which will require a > changelog update)?
Looks good for me, Andrew. The only reason for such whitespace rich format was to make output column aligned. But it's fine to have name:val as well. I'll update. Thanks!
Cyrill
| |