Messages in this thread | | | Date | Sat, 24 Nov 2012 03:03:25 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH RFT] mfd: rc5t583: Fix array subscript is above array bounds |
| |
On Tuesday 20 November 2012 08:04 AM, Axel Lin wrote: > I got below build warning while compiling this driver. > It's obviously RC5T583_MAX_INTERRUPT_MASK_REGS is 9 but irq_en_add array only > has 8 elements. > > CC drivers/mfd/rc5t583-irq.o > drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_sync_unlock': > drivers/mfd/rc5t583-irq.c:227: warning: array subscript is above array bounds > drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_init': > drivers/mfd/rc5t583-irq.c:349: warning: array subscript is above array bounds > > Since the number of interrupt enable registers is 8, this patch adds define for > RC5T583_MAX_INTERRUPT_EN_REGS to fix this bug. > > Signed-off-by: Axel Lin<axel.lin@ingics.com> > --- > Hi Laxman, > I don't have this hardware, I'd appreciate if you can review and test this patch. > Thank you, > Axel
This looks good. I dont see any issue on this. I am planning to move this to regmap-irq, probably on next release.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
| |