Messages in this thread | | | Date | Mon, 26 Nov 2012 11:53:35 +0100 | From | Samuel Ortiz <> | Subject | Re: [PATCH RFT] mfd: rc5t583: Fix array subscript is above array bounds |
| |
Hi Axel,
On Tue, Nov 20, 2012 at 10:34:56AM +0800, Axel Lin wrote: > I got below build warning while compiling this driver. > It's obviously RC5T583_MAX_INTERRUPT_MASK_REGS is 9 but irq_en_add array only > has 8 elements. > > CC drivers/mfd/rc5t583-irq.o > drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_sync_unlock': > drivers/mfd/rc5t583-irq.c:227: warning: array subscript is above array bounds > drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_init': > drivers/mfd/rc5t583-irq.c:349: warning: array subscript is above array bounds > > Since the number of interrupt enable registers is 8, this patch adds define for > RC5T583_MAX_INTERRUPT_EN_REGS to fix this bug. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > Hi Laxman, > I don't have this hardware, I'd appreciate if you can review and test this patch. > Thank you, > Axel > drivers/mfd/rc5t583-irq.c | 2 +- > include/linux/mfd/rc5t583.h | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) Applied, thanks.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |