Messages in this thread | | | Date | Thu, 22 Nov 2012 11:28:36 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver |
| |
On Wed, 21 Nov 2012, Dmitry Torokhov wrote:
> Hi Lee, > > On Wed, Nov 14, 2012 at 01:47:14PM +0000, Lee Jones wrote: > > @@ -272,6 +276,60 @@ static irqreturn_t bu21013_gpio_irq(int irq, void *device_data) > > } > > > > /** > > + * bu21013_gpio_board_init() - configures the touch panel > > + * @reset_pin: reset pin number > > + * > > + * This function is used to configure the voltage and > > + * reset the touch panel controller. > > + */ > > +static int bu21013_gpio_board_init(int reset_pin) > > +{ > > + int retval = 0; > > + > > + bu21013_devices++; > > + if (bu21013_devices == 1) { > > This does not make sense. If gpio is per-device now then we should > simply set it up and not count devices.
No problem. I'll fixup.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |