Messages in this thread Patch in this message | | | Date | Wed, 21 Nov 2012 10:42:56 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver |
| |
Hi Lee,
On Wed, Nov 14, 2012 at 01:47:14PM +0000, Lee Jones wrote: > @@ -272,6 +276,60 @@ static irqreturn_t bu21013_gpio_irq(int irq, void *device_data) > } > > /** > + * bu21013_gpio_board_init() - configures the touch panel > + * @reset_pin: reset pin number > + * > + * This function is used to configure the voltage and > + * reset the touch panel controller. > + */ > +static int bu21013_gpio_board_init(int reset_pin) > +{ > + int retval = 0; > + > + bu21013_devices++; > + if (bu21013_devices == 1) {
This does not make sense. If gpio is per-device now then we should simply set it up and not count devices.
Thanks.
-- Dmitry
| |