Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [PATCH] kfifo: initialize fifo accordingly to C99 standard | Date | Wed, 21 Nov 2012 16:23:20 +0200 |
| |
When build a kernel with "make W=1" we will get a warning about missing initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't initialize the buf[] field of the fifo structure. So, using C99 style helps in such case.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Stefani Seibold <stefani@seibold.net> Cc: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/kfifo.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index 10308c6..3de51a1 100644 --- a/include/linux/kfifo.h +++ b/include/linux/kfifo.h @@ -155,8 +155,7 @@ struct kfifo_rec_ptr_2 __STRUCT_KFIFO_PTR(unsigned char, 2, void); #define DEFINE_KFIFO(fifo, type, size) \ DECLARE_KFIFO(fifo, type, size) = \ (typeof(fifo)) { \ - { \ - { \ + .kfifo = { \ .in = 0, \ .out = 0, \ .mask = __is_kfifo_ptr(&(fifo)) ? \ @@ -166,11 +165,9 @@ struct kfifo_rec_ptr_2 __STRUCT_KFIFO_PTR(unsigned char, 2, void); .data = __is_kfifo_ptr(&(fifo)) ? \ NULL : \ (fifo).buf, \ - } \ } \ } - static inline unsigned int __must_check __kfifo_uint_must_check_helper(unsigned int val) { -- 1.7.10.4
| |