lkml.org 
[lkml]   [2012]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c
Date
Call kfree only if required else return from function.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com>
---
drivers/staging/ozwpan/ozpd.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
index 0b3648c..1dd8980 100644
--- a/drivers/staging/ozwpan/ozpd.c
+++ b/drivers/staging/ozwpan/ozpd.c
@@ -399,11 +399,11 @@ static void oz_tx_frame_free(struct oz_pd *pd, struct oz_tx_frame *f)
f->link.next = pd->tx_pool;
pd->tx_pool = &f->link;
pd->tx_pool_count++;
- f = 0;
+ spin_unlock_bh(&pd->tx_frame_lock);
+ return;
}
spin_unlock_bh(&pd->tx_frame_lock);
- if (f)
- kfree(f);
+ kfree(f);
}
/*------------------------------------------------------------------------------
* Context: softirq-serialized
--
1.7.5.4



\
 
 \ /
  Last update: 2012-11-21 14:21    [W:1.462 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site