| Date | Tue, 20 Nov 2012 09:57:22 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 13/58] RCU: Make rcu_is_cpu_rrupt_from_idle helper functions static |
| |
On Sun, Nov 18, 2012 at 09:27:52PM -0800, Josh Triplett wrote: > Both rcutiny and rcutree define a helper funtion > rcu_is_cpu_rrupt_from_idle, each used exactly once, later in the same > file. Declare these helper functions static. > > Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Hard to argue with this one! I forward-ported to current -rcu and queued for v3.9.
Thanx, Paul
> --- > kernel/rcutiny.c | 2 +- > kernel/rcutree.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/rcutiny.c b/kernel/rcutiny.c > index e4c6a59..0e506c3 100644 > --- a/kernel/rcutiny.c > +++ b/kernel/rcutiny.c > @@ -193,7 +193,7 @@ EXPORT_SYMBOL(rcu_is_cpu_idle); > * interrupts don't count, we must be running at the first interrupt > * level. > */ > -int rcu_is_cpu_rrupt_from_idle(void) > +static int rcu_is_cpu_rrupt_from_idle(void) > { > return rcu_dynticks_nesting <= 0; > } > diff --git a/kernel/rcutree.c b/kernel/rcutree.c > index 74df86b..70d9b6e 100644 > --- a/kernel/rcutree.c > +++ b/kernel/rcutree.c > @@ -783,7 +783,7 @@ EXPORT_SYMBOL_GPL(rcu_lockdep_current_cpu_online); > * interrupt from idle, return true. The caller must have at least > * disabled preemption. > */ > -int rcu_is_cpu_rrupt_from_idle(void) > +static int rcu_is_cpu_rrupt_from_idle(void) > { > return __get_cpu_var(rcu_dynticks).dynticks_nesting <= 1; > } > -- > 1.7.10.4 >
|