lkml.org 
[lkml]   [2012]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 46/58] x86: arch/x86/kernel/irqinit.c: Add prototype for init_IRQ
Date
Josh Triplett <josh@joshtriplett.org> wrote:

> arch/x86/kernel/irqinit.c defines an __init function init_IRQ, called
> from init/main.c. No header file prototypes init_IRQ, because
> init/main.c tends to directly define prototypes for init functions it
> calls, rather than including appropriate headers. So, add a prototype
> of init_IRQ to arch/x86/kernel/irqinit.c right above the definition, to
> satisfy gcc (-Wmissing-prototypes) and Sparse (-Wdecl).

Rather, you should put a declaration for it in a header file.

David


\
 
 \ /
  Last update: 2012-11-19 12:21    [W:0.248 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site