Messages in this thread | | | Date | Fri, 2 Nov 2012 11:29:26 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] Staging: Android: logger: module_exit implementationg |
| |
On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote: > Created the module_exit for the android logger so that > it can be loaded and unloaded as a module. Fixed > module_init and some other minor issues.
That's doing more than one thing here at once, care to break it up? Yeah, I know it seems funny for such a small patch, but it helps.
Also, now that you've added this, the logger driver still can't be built as a module, as the build system isn't changed to let that happen, right?
Also, why do you want to build this as a module?
> Signed-off-by: Luca Clementi <luca.clementi@gmail.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Brian Swetland <swetland@google.com> > --- > drivers/staging/android/logger.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c > index 1d5ed47..050be01 100644 > --- a/drivers/staging/android/logger.c > +++ b/drivers/staging/android/logger.c > @@ -676,4 +676,32 @@ static int __init logger_init(void) > out: > return ret; > } > -device_initcall(logger_init); > + > +static void __exit logger_exit(void) > +{ > + struct logger_log *current_log, *next_log; > + > + list_for_each_entry_safe(current_log, next_log, &log_list, logs) { > + /* we have to delete all the entry inside log_list */ > + ret = misc_deregister(¤t_log->misc); > + if (unlikely(ret)) { > + pr_err("failed to deregister misc device for log '%s'!\n", > + current_log->misc.name); > + } > + pr_info("removed loggger '%s'\n", current_log->misc.name);
Is that message really needed?
> + vfree(current_log->buffer); > + kfree(current_log->misc.name); > + kfree(current_log); > + } > + > + return; > +} > + > + > +module_init(logger_init);
Is module_init() the same "level" as device_initcall()? Did you test this out in an Android system?
> +module_exit(logger_exit); > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR("Brian Swetland, <swetland@google.com>"); > +MODULE_DESCRIPTION("Android Logger"); > + > +
What's with the unneeded trailing empty lines?
thanks,
greg k-h
| |