Messages in this thread |  | | Date | Fri, 2 Nov 2012 22:40:51 -0700 | Subject | Re: [PATCH] Staging: Android: logger: module_exit implementationg | From | Brian Swetland <> |
| |
On Fri, Nov 2, 2012 at 11:29 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote: >> + >> + >> +module_init(logger_init); > > Is module_init() the same "level" as device_initcall()? Did you test > this out in an Android system? > >> +module_exit(logger_exit); >> +MODULE_LICENSE("GPL"); >> +MODULE_AUTHOR("Brian Swetland, <swetland@google.com>"); >> +MODULE_DESCRIPTION("Android Logger"); >> + >> + > > What's with the unneeded trailing empty lines?
Also, module author should be Robert Love (cc'd), unless he'd rather not be credited, in which case "Google, Inc" or no listed author is fine.
Brian
|  |