lkml.org 
[lkml]   [2012]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] netcls_cgroup: implement proper hierarchy support
Hi Tejun,

On 19.11.2012 18:08, Tejun Heo wrote:
> Hello, Daniel.
>
> On Mon, Nov 19, 2012 at 02:47:06PM +0100, Daniel Wagner wrote:
>> On 17.11.2012 04:31, Tejun Heo wrote:
>>> @@ -112,15 +161,6 @@ struct cgroup_subsys net_cls_subsys = {
>>> .subsys_id = net_cls_subsys_id,
>>> .base_cftypes = ss_files,
>>> .module = THIS_MODULE,
>>> -
>>> - /*
>>> - * While net_cls cgroup has the rudimentary hierarchy support of
>>> - * inheriting the parent's classid on cgroup creation, it doesn't
>>> - * properly propagates config changes in ancestors to their
>>> - * descendents. A child should follow the parent's configuration
>>> - * but be allowed to override it. Fix it and remove the following.
>>> - */
>>> - .broken_hierarchy = true,
>>> };
>>
>> Are you sure you want to set the default to false at this point?
>
> Hmmm.... why not? It's now implementing proper hierarchy behavior.

Well, I though the rule is to keep API as stable as possible. On second
though this change will only extend the API, so for the existing
user base nothing changes.

Acked-by: Daniel Wagner <daniel.wagner@bmw-carit.de>

thanks,
daniel


\
 
 \ /
  Last update: 2012-11-19 21:01    [W:0.049 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site