Messages in this thread | | | Date | Mon, 19 Nov 2012 09:08:59 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 3/3] netcls_cgroup: implement proper hierarchy support |
| |
Hello, Daniel.
On Mon, Nov 19, 2012 at 02:47:06PM +0100, Daniel Wagner wrote: > On 17.11.2012 04:31, Tejun Heo wrote: > >@@ -112,15 +161,6 @@ struct cgroup_subsys net_cls_subsys = { > > .subsys_id = net_cls_subsys_id, > > .base_cftypes = ss_files, > > .module = THIS_MODULE, > >- > >- /* > >- * While net_cls cgroup has the rudimentary hierarchy support of > >- * inheriting the parent's classid on cgroup creation, it doesn't > >- * properly propagates config changes in ancestors to their > >- * descendents. A child should follow the parent's configuration > >- * but be allowed to override it. Fix it and remove the following. > >- */ > >- .broken_hierarchy = true, > > }; > > Are you sure you want to set the default to false at this point?
Hmmm.... why not? It's now implementing proper hierarchy behavior.
Thanks.
-- tejun
| |