lkml.org 
[lkml]   [2012]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/19] mm: numa: Add fault driven placement and migration

* Mel Gorman <mgorman@suse.de> wrote:

> NOTE: This patch is based on "sched, numa, mm: Add fault driven
> placement and migration policy" but as it throws away
> all the policy to just leave a basic foundation I had to
> drop the signed-offs-by.

So, much of that has been updated meanwhile - but the split
makes fundamental sense - we considered it before.

One detail you did in this patch was the following rename:

s/EMBEDDED_NUMA/NUMA_VARIABLE_LOCALITY

> --- a/arch/sh/mm/Kconfig
> +++ b/arch/sh/mm/Kconfig
> @@ -111,6 +111,7 @@ config VSYSCALL
> config NUMA
> bool "Non Uniform Memory Access (NUMA) Support"
> depends on MMU && SYS_SUPPORTS_NUMA && EXPERIMENTAL
> + select NUMA_VARIABLE_LOCALITY
> default n
> help
> Some SH systems have many various memories scattered around
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
>
..aaba45d 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -696,6 +696,20 @@ config LOG_BUF_SHIFT
> config HAVE_UNSTABLE_SCHED_CLOCK
> bool
>
> +#
> +# For architectures that (ab)use NUMA to represent different memory regions
> +# all cpu-local but of different latencies, such as SuperH.
> +#
> +config NUMA_VARIABLE_LOCALITY
> + bool

The NUMA_VARIABLE_LOCALITY name slightly misses the real point
though that NUMA_EMBEDDED tried to stress: it's important to
realize that these are systems that (ab-)use our NUMA memory
zoning code to implement support for variable speed RAM modules
- so they can use the existing node binding ABIs.

The cost of that is the losing of the regular NUMA node
structure. So by all means it's a convenient hack - but the name
must signal that. I'm not attached to the NUMA_EMBEDDED naming
overly strongly, but NUMA_VARIABLE_LOCALITY sounds more harmless
than it should.

Perhaps ARCH_WANT_NUMA_VARIABLE_LOCALITY_OVERRIDE? A tad long
but we don't want it to be overused in any case.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-11-13 12:21    [W:1.184 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site