lkml.org 
[lkml]   [2012]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/19] mm: numa: teach gup_fast about pmd_numa

* Mel Gorman <mgorman@suse.de> wrote:

> On Tue, Nov 13, 2012 at 11:07:36AM +0100, Ingo Molnar wrote:
> >
> > * Mel Gorman <mgorman@suse.de> wrote:
> >
> > > From: Andrea Arcangeli <aarcange@redhat.com>
> > >
> > > When scanning pmds, the pmd may be of numa type (_PAGE_PRESENT not set),
> > > however the pte might be present. Therefore, gup_pmd_range() must return
> > > 0 in this case to avoid losing a NUMA hinting page fault during gup_fast.
> > >
> > > Note: gup_fast will skip over non present ptes (like numa
> > > types), so no explicit check is needed for the pte_numa case.
> > > [...]
> >
> > So, why not fix all architectures that choose to expose
> > pte_numa() and pmd_numa() methods - via the patch below?
> >
>
> I'll pick it up. Thanks.

FYI, before you do too much restructuring work, that patch is
already part of tip:numa/core, I'll push out our updated version
of the tree later today.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-11-13 15:21    [W:0.247 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site