Messages in this thread | | | Date | Thu, 4 Oct 2012 10:46:26 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: Seems like "sched: Add missing call to calc_load_exit_idle()" should be reverted in 3.5 branch |
| |
On Thu, Oct 04, 2012 at 12:11:01PM +0800, Huacai Chen wrote: > Hi, Greg > > I found that Linux-3.5.5 accept this commit "sched: Add missing call > to calc_load_exit_idle()" but I think this isn't needed. Because > "5167e8d5417b sched/nohz: Rewrite and fix load-avg computation -- > again not fully applied" is true for 3.6 branch, but not for 3.5 > branch.
But 5167e8d5417b is in 3.5, so shouldn't this commit still be necessary?
> In 3.5 branch, calc_load_exit_idle() is already called in > tick_nohz_idle_exit(), it doesn't need to be called at > tick_nohz_update_jiffies() again. In 3.6 branch, some code of > tick_nohz_idle_exit() is splitted to tick_nohz_restart_sched_tick() > and calc_load_exit_idle() is missing by accident, so commit "sched: > Add missing call to calc_load_exit_idle()" is needed.
So this really should be dropped from 3.5? Charles, Peter, Ingo, any thoughts here?
thanks,
greg k-h
| |