Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 14/14] perf diff: Display empty space for non paired samples | Date | Thu, 04 Oct 2012 15:06:56 +0900 |
| |
On Thu, 27 Sep 2012 13:09:35 +0200, Jiri Olsa wrote: > Currently in 'Baseline' and 'Period Base' columns zero values are > displayed in case no pair is found for the sample. This might be > confusing, using empty space instead. [snip] > @@ -246,8 +249,12 @@ static int hpp__entry_period_baseline(struct perf_hpp *hpp, struct hist_entry *h > u64 period = pair ? pair->period : 0; > const char *fmt = symbol_conf.field_sep ? "%" PRIu64 : "%12" PRIu64; > > - return scnprintf(hpp->buf, hpp->size, fmt, period); > + if (pair) > + return scnprintf(hpp->buf, hpp->size, fmt, period); > + else > + return scnprintf(hpp->buf, hpp->size, " ");
It seems that it's not needed when -t (field separator) switch is given.
Thanks, Namhyung
| |