lkml.org 
[lkml]   [2012]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 14/14] perf diff: Display empty space for non paired samples
Date
On Thu, 27 Sep 2012 13:09:35 +0200, Jiri Olsa wrote:
> Currently in 'Baseline' and 'Period Base' columns zero values are
> displayed in case no pair is found for the sample. This might be
> confusing, using empty space instead.
[snip]
> @@ -246,8 +249,12 @@ static int hpp__entry_period_baseline(struct perf_hpp *hpp, struct hist_entry *h
> u64 period = pair ? pair->period : 0;
> const char *fmt = symbol_conf.field_sep ? "%" PRIu64 : "%12" PRIu64;
>
> - return scnprintf(hpp->buf, hpp->size, fmt, period);
> + if (pair)
> + return scnprintf(hpp->buf, hpp->size, fmt, period);
> + else
> + return scnprintf(hpp->buf, hpp->size, " ");

It seems that it's not needed when -t (field separator) switch is given.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2012-10-04 09:01    [W:0.188 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site