lkml.org 
[lkml]   [2012]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 00/14] perf diff: Factor diff command
On Thu, Sep 27, 2012 at 11:31:02PM +0200, Andi Kleen wrote:
> On Thu, Sep 27, 2012 at 01:09:21PM +0200, Jiri Olsa wrote:
> > hi,
> > this is v2 of diff command changes proposed in here:
> > https://lkml.org/lkml/2012/9/6/344
> >
> > It's now rebased on new hists hpp* interface plus few
> > more additional changes.
>
> FWIW I've been playing around with it a bit. It seems useful
> both for scaling problems and likely for performance regression tracking too.

cool ;)

>
> Some minor issues I ran into (but no show stoppers):
> - The error messages for bad -c expressions could be better
> - I found the requirement for no space after -c unintuitive.

I'll see to that

> - It would be nice to have support for doing the bucketizing per line
> instead of per function. With a large function and/or inlining
> it's sometimes hard to identify the actual problem
> Acme recently added this for perf report.

hm, I missed this one.. hopefully it should be no problem to add it

thanks for testing this!
jirka


\
 
 \ /
  Last update: 2012-10-01 11:01    [W:0.394 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site