Messages in this thread | | | Date | Tue, 2 Oct 2012 23:49:03 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 7/10] compiler{,-gcc4}.h: Introduce __flatten function attribute |
| |
On Fri, 28 Sep 2012, Josh Triplett wrote:
> That issue doesn't relate to __flatten, though; it only relates to > __weak. Since __flatten (and __compiletime_object_size) will work fine > on 4.1.0 and 4.1.1, don't exclude them just because the definition for > __weak elsewhere in the file excludes them. That just makes it harder > for anyone who might want to work on the issue with __weak. >
Nack to the patch since there are no users of it; there's no need to define every possible gcc function attribute. If anything actually needs to use __attribute__((flatten)), then it can introduce it.
| |