Messages in this thread | | | From | "Tatulea, Dragos" <> | Date | Thu, 25 Oct 2012 14:25:26 +0300 | Subject | Re: [PATCH 02/26] pstore: add flags |
| |
On Tue, Oct 23, 2012 at 7:57 PM, Luck, Tony <tony.luck@intel.com> wrote: >> I wonder if the default should be to not show headers, and to add this >> flag to the backends that want the pstore-added header. I think the >> more common case going forward will to be without headers since >> backends should arguably storing metadata themselves. > > Perhaps just add the headings when pstore breaks a dump into > pieces because of a back-end size limitation. I.e. if there is only > one piece, then no headings. If there are two or more, include > a heading to aid with putting the pieces together later. > But how do you determine the kmsg data size without doing a kmsg_dump_get_buffer beforehand?
Thanks, Dragos
| |