lkml.org 
[lkml]   [2012]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/26] pstore: add flags
From
On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea <irina.tirdea@intel.com> wrote:
> From: Adrian Hunter <adrian.hunter@intel.com>
>
> Let the back end tweak pstore behaviour. Flags added are:
>
> PSTORE_NO_HEADINGS
>
> Omit pstore heading lines from dumped data

I wonder if the default should be to not show headers, and to add this
flag to the backends that want the pstore-added header. I think the
more common case going forward will to be without headers since
backends should arguably storing metadata themselves.

Thoughts?

> PSTORE_MAX_KMSG_BYTES
>
> Default kmsg_bytes to ULONG_MAX
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>

Either way, this patch looks logically fine to me.

-Kees

--
Kees Cook
Chrome OS Security


\
 
 \ /
  Last update: 2012-10-23 19:41    [W:0.544 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site