Messages in this thread | | | Date | Tue, 23 Oct 2012 09:54:42 -0700 | Subject | Re: [PATCH 02/26] pstore: add flags | From | Kees Cook <> |
| |
On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea <irina.tirdea@intel.com> wrote: > From: Adrian Hunter <adrian.hunter@intel.com> > > Let the back end tweak pstore behaviour. Flags added are: > > PSTORE_NO_HEADINGS > > Omit pstore heading lines from dumped data
I wonder if the default should be to not show headers, and to add this flag to the backends that want the pstore-added header. I think the more common case going forward will to be without headers since backends should arguably storing metadata themselves.
Thoughts?
> PSTORE_MAX_KMSG_BYTES > > Default kmsg_bytes to ULONG_MAX > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Either way, this patch looks logically fine to me.
-Kees
-- Kees Cook Chrome OS Security
| |