| Date | Thu, 25 Oct 2012 11:45:52 +0800 | Subject | Re: [PATCH V2 6/6] Thermal: Add ST-Ericsson DB8500 thermal properties and platform data. | From | Hongbo Zhang <> |
| |
On 24 October 2012 22:32, Joe Perches <joe@perches.com> wrote: > On Wed, 2012-10-24 at 19:58 +0800, hongbo.zhang wrote: >> This patch adds device tree properties for ST-Ericsson DB8500 thermal driver, >> also adds the platform data to support the old fashion. > > Just a trivial note: > >> diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c > >> @@ -229,6 +230,67 @@ static struct ab8500_platform_data ab8500_platdata = { >> }; >> >> /* >> + * Thermal Sensor >> + */ >> + >> +static struct resource db8500_thsens_resources[] = { > > should there be a const in any of these? There will be warnings from gcc: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
> >> +static struct db8500_thsens_platform_data db8500_thsens_data = { > [] >> +static struct platform_device u8500_thsens_device = { > [] >> +static struct platform_device u8500_cpufreq_cooling_device = { > >
|