Messages in this thread | | | Subject | Re: [PATCH v3] pwm: vt8500: Update vt8500 PWM driver support | From | Tony Prisk <> | Date | Thu, 25 Oct 2012 06:35:46 +1300 |
| |
On Wed, 2012-10-24 at 07:41 +0200, Thierry Reding wrote: > On Wed, Oct 24, 2012 at 04:46:58PM +1300, Tony Prisk wrote: > > This patch updates pwm-vt8500.c to support devicetree probing and > > make use of the common clock subsystem. > > > > A binding document describing the PWM controller found on > > arch-vt8500 is also included. > > > > Signed-off-by: Tony Prisk <linux@prisktech.co.nz> > > --- > > v2/v3: > > Fix errors/coding style as pointed out by Thierry Reding. > > > > .../devicetree/bindings/pwm/vt8500-pwm.txt | 17 ++++ > > drivers/pwm/pwm-vt8500.c | 86 ++++++++++++++------ > > 2 files changed, 80 insertions(+), 23 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/pwm/vt8500-pwm.txt > > Looking real good now. One last comment though and I think I'm ready to > take this... > > > + err = clk_enable(vt8500->clk); > > + if (err < 0) > > + dev_err(chip->dev, "failed to enable clock\n"); > > + return -EBUSY; > > + }; > > Why do you return EBUSY instead of err?
Because I didn't notice this when I 'fixed' it - I changed the other one to return err/ret, missed this one. Will fix. > > Thierry > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |