lkml.org 
[lkml]   [2012]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] pwm: vt8500: Update vt8500 PWM driver support
On Wed, Oct 24, 2012 at 04:46:58PM +1300, Tony Prisk wrote:
> This patch updates pwm-vt8500.c to support devicetree probing and
> make use of the common clock subsystem.
>
> A binding document describing the PWM controller found on
> arch-vt8500 is also included.
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> ---
> v2/v3:
> Fix errors/coding style as pointed out by Thierry Reding.
>
> .../devicetree/bindings/pwm/vt8500-pwm.txt | 17 ++++
> drivers/pwm/pwm-vt8500.c | 86 ++++++++++++++------
> 2 files changed, 80 insertions(+), 23 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/pwm/vt8500-pwm.txt

Looking real good now. One last comment though and I think I'm ready to
take this...

> + err = clk_enable(vt8500->clk);
> + if (err < 0)
> + dev_err(chip->dev, "failed to enable clock\n");
> + return -EBUSY;
> + };

Why do you return EBUSY instead of err?

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-10-24 08:21    [W:0.049 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site