| Subject | Re: [PATCH 14/34] perf, x86: Avoid checkpointed counters causing excessive TSX aborts | From | Peter Zijlstra <> | Date | Tue, 23 Oct 2012 15:05:05 +0200 |
| |
On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote: > + /* XXX move somewhere else. */ > + if (cpuc->events[2] && (cpuc->events[2]->hw.config & HSW_INTX_CHECKPOINTED)) > + status |= (1ULL << 2);
A comment explaining about those 'spurious' PMIs would go along with this nicely, no? I'm very sure I'd keep having to look up the commit introducing this to figure out wtf its for.
|