lkml.org 
[lkml]   [2012]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 14/34] perf, x86: Avoid checkpointed counters causing excessive TSX aborts
From
Date
On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote:
> + /* XXX move somewhere else. */
> + if (cpuc->events[2] && (cpuc->events[2]->hw.config & HSW_INTX_CHECKPOINTED))
> + status |= (1ULL << 2);

A comment explaining about those 'spurious' PMIs would go along with
this nicely, no? I'm very sure I'd keep having to look up the commit
introducing this to figure out wtf its for.


\
 
 \ /
  Last update: 2012-10-23 15:41    [W:0.288 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site