Messages in this thread | | | Date | Tue, 23 Oct 2012 18:17:31 +0800 | From | Miao Xie <> | Subject | Re: [PATCH v2 1/2] Replace if statement with WARN_ON_ONCE() in cmci_rediscover(). |
| |
On tue, 23 Oct 2012 11:52:34 +0200, Borislav Petkov wrote: > On Tue, Oct 23, 2012 at 10:55:13AM +0800, Tang Chen wrote: >> So, how about warn once, and continue: >> if (cpu == dying) { >> WARN_ON_ONCE(cpu == dying); >> continue; >> } >> >> or, use BUG_ON() instead ? > > Let me ask you again, but I want you to think real hard this time: > > "Why do we need to warn? What good would that bring us?" >
This function is called after a cpu is offline, in other words, it is impossible that the cpu is still in cpu_online_mask. otherwise there is something wrong in the code.
Thanks Miao
| |