Messages in this thread | | | Date | Tue, 23 Oct 2012 10:55:13 +0800 | From | Tang Chen <> | Subject | Re: [PATCH v2 1/2] Replace if statement with WARN_ON_ONCE() in cmci_rediscover(). |
| |
On 10/22/2012 06:14 PM, Borislav Petkov wrote: > On Mon, Oct 22, 2012 at 10:10:24AM +0800, Tang Chen wrote: >> I don't why before we just jumped over it. But I think if we have an >> online cpu == dying here, it must be wrong. So I think we should warn >> it, not just jump over it. > > Why do we need to warn? What good would that bring us? > > AFAICT, the check in cmci_rediscover is there to make sure we absolutely > don't rediscover on the dying cpu. I think it is a safety precaution in > concurrency scenarios between cpu hotplug and mce code.
Well, I see. I dropped the if statement. :)
So, how about warn once, and continue: if (cpu == dying) { WARN_ON_ONCE(cpu == dying); continue; }
or, use BUG_ON() instead ?
> > Thanks. >
| |