Messages in this thread Patch in this message | | | From | Ezequiel Garcia <> | Subject | [PATCH 2/2] mm/slob: Use free_page instead of put_page for page-size kmalloc allocations | Date | Mon, 22 Oct 2012 09:04:31 -0300 |
| |
When freeing objects, the slob allocator currently free empty pages calling __free_pages(). However, page-size kmallocs are disposed using put_page() instead.
It makes no sense to call put_page() for kernel pages that are provided by the object allocator, so we shouldn't be doing this ourselves.
This is based on: commit d9b7f22623b5fa9cc189581dcdfb2ac605933bf4 Author: Glauber Costa <glommer@parallels.com> slub: use free_page instead of put_page for freeing kmalloc allocation
Cc: Christoph Lameter <cl@linux-foundation.org> Cc: Pekka Enberg <penberg@kernel.org> Cc: Matt Mackall <mpm@selenic.com> Cc: Glauber Costa <glommer@parallels.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> --- mm/slob.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/slob.c b/mm/slob.c index a65e802..362632d 100644 --- a/mm/slob.c +++ b/mm/slob.c @@ -506,7 +506,7 @@ void kfree(const void *block) unsigned int *m = (unsigned int *)(block - align); slob_free(m, *m + align); } else - put_page(sp); + __free_pages(sp, compound_order(sp)); } EXPORT_SYMBOL(kfree); -- 1.7.8.6
| |