Messages in this thread | | | Subject | Re: [PATCH 1/2] staging: android: checkpatch.pl fixes | From | Cruz Julian Bishop <> | Date | Sun, 21 Oct 2012 12:05:21 +1000 |
| |
On Sat, 2012-10-20 at 18:05 -0700, Joe Perches wrote: > On Sat, 2012-10-20 at 23:33 +0100, Ken O'Brien wrote: > > Fixed all instances of strings spanning multiple lines from checkpatch.pl. > [] > > diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c > [] > > @@ -556,7 +556,7 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate, > > goto free_range; > > > > if (vma == NULL) { > > - pr_err("binder: %d: binder_alloc_buf failed to " > > + pr_err("binder: %d: binder_alloc_buf failed to " \ > > "map pages in userspace, no vma\n", proc->pid); > > Hi Ken. > > Nice try, but the "right" way to do this is to coalesce formats like: > > pr_err("binder: %d: binder_alloc_buf failed to map pages in userspace, no vma\n", > proc->pid); > > and ignore 80 column line lengths for these coalesced formats.
Going off that, is there currently any way to insert, say, a comment that filters out the next line for checkpatch errors?
For example,
/* checkpatch_ignore_(rulename) */ (Long line that can't be broken here)
> > An even better way is to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > before any #include and change the format to: > > pr_err("%d: binder_alloc_buf failed to map pages in userspace, no vma\n", > proc->pid); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |