lkml.org 
[lkml]   [2012]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] staging: android: checkpatch.pl fixes
From
Date
On Sat, 2012-10-20 at 23:33 +0100, Ken O'Brien wrote:
> Fixed all instances of strings spanning multiple lines from checkpatch.pl.
[]
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -556,7 +556,7 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate,
> goto free_range;
>
> if (vma == NULL) {
> - pr_err("binder: %d: binder_alloc_buf failed to "
> + pr_err("binder: %d: binder_alloc_buf failed to " \
> "map pages in userspace, no vma\n", proc->pid);

Hi Ken.

Nice try, but the "right" way to do this is to coalesce formats like:

pr_err("binder: %d: binder_alloc_buf failed to map pages in userspace, no vma\n",
proc->pid);

and ignore 80 column line lengths for these coalesced formats.

An even better way is to add

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

before any #include and change the format to:

pr_err("%d: binder_alloc_buf failed to map pages in userspace, no vma\n",
proc->pid);




\
 
 \ /
  Last update: 2012-10-21 03:41    [W:0.063 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site