Messages in this thread | | | Subject | Re: [PATCH REGRESSION FIX] dw_dmac: make driver's endianness configurable | From | Andy Shevchenko <> | Date | Mon, 15 Oct 2012 10:31:50 +0300 |
| |
On Mon, 2012-10-15 at 08:39 +0800, Hein Tibosch wrote: > Hi Andy, > On 10/15/2012 4:08 AM, Andy Shevchenko wrote: > > On Sun, Oct 14, 2012 at 10:54 AM, Hein Tibosch <hein_tibosch@yahoo.es> wrote: > >> From: Hein Tibosch <hein_tibosch@yahoo.es> > >> > >> The dw_dmac was originally developed for avr32 to be used with the Synopsys > >> DesignWare AHB DMA controller. Starting from 2.6.38, access to the device's i/o > >> <snip> > >> #define dma_readl(dw, name) \ > >> - readl(&(__dw_regs(dw)->name)) > >> + dma_readl_native(&(__dw_regs(dw)->name)) > >> #define dma_writel(dw, name, val) \ > >> - writel((val), &(__dw_regs(dw)->name)) > >> + dma_writel_native((val), &(__dw_regs(dw)->name)) > >> > >> #define channel_set_bit(dw, reg, mask) \ > >> dma_writel(dw, reg, ((mask) << 8) | (mask)) > > Why did you not change this one? > > Because "dma_writel" already calls "dma_writel_native" Sure, looks good for me.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |