Messages in this thread | | | Subject | Re: [RFC net-next] treewide: s/ipv4_is_<foo>()/ipv4_addr_<foo>/ | From | Joe Perches <> | Date | Thu, 11 Oct 2012 01:28:35 -0700 |
| |
On Thu, 2012-10-11 at 09:11 +0100, David Laight wrote: > > ipv4 and ipv6 use different styles for these tests. > > > > ipv4_is_<foo>(__be32) > > ipv6_addr_<foo>(struct in6_addr *) > > I presume there is a 'const' in there ... > > > Perhaps it'd be good to convert the ipv4 tests to the ipv6 style. > > You don't want to force an IPv4 address (which might be in a register) > be written out to stack. > Taking the address also has implications for the optimiser.
Of course not, I'm just talking about renaming.
| |