Messages in this thread | | | Subject | RE: [RFC net-next] treewide: s/ipv4_is_<foo>()/ipv4_addr_<foo>/ | Date | Thu, 11 Oct 2012 09:11:18 +0100 | From | "David Laight" <> |
| |
> ipv4 and ipv6 use different styles for these tests. > > ipv4_is_<foo>(__be32) > ipv6_addr_<foo>(struct in6_addr *)
I presume there is a 'const' in there ...
> Perhaps it'd be good to convert the ipv4 tests to the ipv6 style.
You don't want to force an IPv4 address (which might be in a register) be written out to stack. Taking the address also has implications for the optimiser.
David
| |