Messages in this thread | | | Subject | RE: [PATCH net-next?] pktgen: Use simpler test for non-zero ipv6 address | Date | Thu, 11 Oct 2012 09:08:52 +0100 | From | "David Laight" <> |
| |
> - if (pkt_dev->min_in6_daddr.s6_addr32[0] == 0 && > - pkt_dev->min_in6_daddr.s6_addr32[1] == 0 && > - pkt_dev->min_in6_daddr.s6_addr32[2] == 0 && > - pkt_dev->min_in6_daddr.s6_addr32[3] == 0) ; > - else { > + if (pkt_dev->min_in6_daddr.s6_addr32[0] | > + pkt_dev->min_in6_daddr.s6_addr32[1] | > + pkt_dev->min_in6_daddr.s6_addr32[2] | > + pkt_dev->min_in6_daddr.s6_addr32[3]) {
Given the likely values, it might be worth using: if (pkt_dev->min_in6_daddr.s6_addr32[0] == 0 && pkt_dev->min_in6_daddr.s6_addr32[1] | pkt_dev->min_in6_daddr.s6_addr32[2] | pkt_dev->min_in6_daddr.s6_addr32[3]) {
David
| |