Messages in this thread | | | Subject | Re: [PATCH v6 6/6] tracing: Fix maybe-uninitialized warning in ftrace_function_set_regexp | From | Steven Rostedt <> | Date | Thu, 11 Oct 2012 21:36:52 -0400 |
| |
On Thu, 2012-10-11 at 16:27 -0700, David Sharp wrote: > Compiler warning: > > kernel/trace/trace_events_filter.c: In function 'ftrace_function_set_filter_cb': > kernel/trace/trace_events_filter.c:2074:8: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > Signed-off-by: David Sharp <dhsharp@google.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > --- > kernel/trace/trace_events_filter.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c > index 431dba8..ef36953 100644 > --- a/kernel/trace/trace_events_filter.c > +++ b/kernel/trace/trace_events_filter.c > @@ -2002,9 +2002,10 @@ static int ftrace_function_set_regexp(struct ftrace_ops *ops, int filter, > static int __ftrace_function_set_filter(int filter, char *buf, int len, > struct function_filter_data *data) > { > - int i, re_cnt, ret; > + int i, re_cnt; > int *reset; > char **re; > + int ret = 0; > > reset = filter ? &data->first_filter : &data->first_notrace; >
It has already been fixed in mainline:
92d8d4a8b0f4c6eba70f6e62b48e38bd005a56e6
http://marc.info/?l=linux-kernel&m=134012157512078
-- Steve
| |