Messages in this thread | | | From | David Sharp <> | Date | Mon, 15 Oct 2012 12:05:08 -0700 | Subject | Re: [PATCH v6 1/6] tracing,x86: Add a TSC trace_clock |
| |
On Fri, Oct 12, 2012 at 4:41 AM, Steven Rostedt <rostedt@goodmis.org> wrote: > On Fri, 2012-10-12 at 07:05 +0200, Geert Uytterhoeven wrote: >> On Fri, Oct 12, 2012 at 1:27 AM, David Sharp <dhsharp@google.com> wrote: >> > +#include <asm-generic/trace_clock.h> >> >> Please use the Kbuild infrastructure ("generic-y += ..." in >> arch/*/include/asm/Kbuild) >> instead of adding wrappers around the asm-generic version. > > So that's how that's done. Learn something new everyday. Too bad the one > file I checked (div64.h) doesn't seem to do it for ia64 and others. > > Can we please have someone clean up all the archs and remove any *.h > wrappers and use the kbuild infrastructure instead. That way, when > another developer goes to look at how this is done, they wont copy the > wrong method again. (Maybe I'll just do it :-p) > > David, > > Can you just send an update of this one patch.
Will do. Thanks for the education, Geert. :)
d#
| |