Messages in this thread | | | Date | Thu, 11 Oct 2012 14:18:04 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH] Platform: hp-wmi: add rfkill support for integrated GPS |
| |
On Thu, Oct 11, 2012 at 03:15:47PM +0200, Trepák Vilmos wrote: > On Thu, 2012-10-11 at 13:34 +0100, Matthew Garrett wrote: > > I don't think this bit is right - in this codepath, wireless is a mask, > > so 0x3 would mean wifi and bluetooth, not gps. I'd expect gps to be 0x8. > > And you'd expect right. Re-tested with 0x8, it works.
Ok.
> > > > The rest looks good, though. > > > > Of course it does, it's just copy & paste & replace... I don't even > think I deserve credit for it. > > Is it worth it to resubmit the patch for a 1-byte change or will you > just take care of it yourself? If it's easier for you, I'll resubmit.
No worries, I'll fix it up. Thanks!
-- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |