lkml.org 
[lkml]   [2012]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Platform: hp-wmi: add rfkill support for integrated GPS
On Thu, Oct 11, 2012 at 12:51:00PM +0200, Trepák Vilmos wrote:
> @@ -663,6 +669,24 @@ static int __devinit hp_wmi_rfkill_setup
> goto register_bluetooth_error;
> }
>
> + if (wireless & 0x3) {
> + gps_rfkill = rfkill_alloc("hp-gps", &device->dev,
> + RFKILL_TYPE_GPS,
> + &hp_wmi_rfkill_ops,
> + (void *) HPWMI_GPS);

I don't think this bit is right - in this codepath, wireless is a mask,
so 0x3 would mean wifi and bluetooth, not gps. I'd expect gps to be 0x8.
The rest looks good, though.


--
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-10-11 15:21    [W:0.050 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site