| Date | Tue, 02 Oct 2012 00:53:02 +0200 | From | Willy Tarreau <> | Subject | [ 065/180] nfsd: dont allow zero length strings in cache_parse() |
| |
2.6.32-longterm review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter <dan.carpenter@oracle.com>
commit 6d8d17499810479eabd10731179c04b2ca22152f upstream.
There is no point in passing a zero length string here and quite a few of that cache_parse() implementations will Oops if count is zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Willy Tarreau <w@1wt.eu> --- net/sunrpc/cache.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c index 25f7801..e3fea46 100644 --- a/net/sunrpc/cache.c +++ b/net/sunrpc/cache.c @@ -719,6 +719,8 @@ static ssize_t cache_do_downcall(char *kaddr, const char __user *buf, { ssize_t ret; + if (count == 0) + return -EINVAL; if (copy_from_user(kaddr, buf, count)) return -EFAULT; kaddr[count] = '\0'; -- 1.7.2.1.45.g54fbc
|