lkml.org 
[lkml]   [2012]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 118/180] ALSA: mpu401: Fix missing initialization of irq field
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit bc733d495267a23ef8660220d696c6e549ce30b3 upstream.

    The irq field of struct snd_mpu401 is supposed to be initialized to -1.
    Since it's set to zero as of now, a probing error before the irq
    installation results in a kernel warning "Trying to free already-free
    IRQ 0".

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=44821
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    sound/drivers/mpu401/mpu401_uart.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/sound/drivers/mpu401/mpu401_uart.c b/sound/drivers/mpu401/mpu401_uart.c
    index 2af0999..74f5a3d 100644
    --- a/sound/drivers/mpu401/mpu401_uart.c
    +++ b/sound/drivers/mpu401/mpu401_uart.c
    @@ -554,6 +554,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device,
    spin_lock_init(&mpu->output_lock);
    spin_lock_init(&mpu->timer_lock);
    mpu->hardware = hardware;
    + mpu->irq = -1;
    if (! (info_flags & MPU401_INFO_INTEGRATED)) {
    int res_size = hardware == MPU401_HW_PC98II ? 4 : 2;
    mpu->res = request_region(port, res_size, "MPU401 UART");
    --
    1.7.2.1.45.g54fbc




    \
     
     \ /
      Last update: 2012-10-02 06:01    [W:2.506 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site