Messages in this thread | | | Subject | Re: [PATCH] tools lib traceevent: Fix missed freeing of subargs in free_arg() in filter | From | Steven Rostedt <> | Date | Mon, 01 Oct 2012 09:42:25 -0400 |
| |
On Mon, 2012-10-01 at 22:16 +0900, Namhyung Kim wrote:
> Although they have same layout, wouldn't it be better using their own > fields? > > case FILTER_ARG_NUM: > free_arg(arg->num.left); > free_arg(arg->num.right); > break; > > case FILTER_ARG_EXP: > free_arg(arg->exp.left); > free_arg(arg->exp.right); > break;
Yeah, I got lazy. This is probably better. I'll resend.
Thanks,
-- Steve
| |