lkml.org 
[lkml]   [2012]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tools lib traceevent: Fix missed freeing of subargs in free_arg() in filter
From
Date
On Mon, 2012-10-01 at 22:16 +0900, Namhyung Kim wrote:

> Although they have same layout, wouldn't it be better using their own
> fields?
>
> case FILTER_ARG_NUM:
> free_arg(arg->num.left);
> free_arg(arg->num.right);
> break;
>
> case FILTER_ARG_EXP:
> free_arg(arg->exp.left);
> free_arg(arg->exp.right);
> break;

Yeah, I got lazy. This is probably better. I'll resend.

Thanks,

-- Steve




\
 
 \ /
  Last update: 2012-10-01 16:21    [W:0.033 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site